svn commit: r306682 - stable/11/sys/fs/nullfs

Mateusz Guzik mjg at FreeBSD.org
Tue Oct 4 18:04:47 UTC 2016


Author: mjg
Date: Tue Oct  4 18:04:46 2016
New Revision: 306682
URL: https://svnweb.freebsd.org/changeset/base/306682

Log:
  MFC r305659:
  
  nullfs: plug vnode ref leak in null_vptocnp
  
  The lower vnode is already referenced and nodeget is supposed to consume
  the reference. Thus the extra vref call was causing a leak.

Modified:
  stable/11/sys/fs/nullfs/null_vnops.c
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/sys/fs/nullfs/null_vnops.c
==============================================================================
--- stable/11/sys/fs/nullfs/null_vnops.c	Tue Oct  4 17:57:30 2016	(r306681)
+++ stable/11/sys/fs/nullfs/null_vnops.c	Tue Oct  4 18:04:46 2016	(r306682)
@@ -896,7 +896,6 @@ null_vptocnp(struct vop_vptocnp_args *ap
 		vn_lock(vp, locked | LK_RETRY);
 		return (ENOENT);
 	}
-	vref(ldvp);
 	error = null_nodeget(vp->v_mount, ldvp, dvp);
 	if (error == 0) {
 #ifdef DIAGNOSTIC


More information about the svn-src-stable-11 mailing list