svn commit: r322513 - stable/10/sys/geom/journal

[Li-Wen Hsu]

On Mon, Aug 14, 2017 at 19:12:52 +0000, Kirk McKusick wrote:
> Author: mckusick
> Date: Mon Aug 14 19:12:51 2017
> New Revision: 322513
> URL: https://svnweb.freebsd.org/changeset/base/322513
> 
> Log:
>   MFC of 322178:
>   
>   Bug 198500 reports bad sysctl values for gjournal cache limit.
>   
>   PR: 198500
>   Submitted by: Dr. Andreas Longwitz <longwitz at incore.de>
>   Reported by: Eugene Grosbein
>   Discussed with: kib
>   Approved by: re (marius)
> 
> Modified:
>   stable/10/sys/geom/journal/g_journal.c
> Directory Properties:
>   stable/10/   (props changed)

This change seems breaking build:

/usr/src/sys/modules/geom/geom_journal/../../../geom/journal/g_journal.c:136:1: error: incompatible pointer types initializing 'int *' with an expression of type 'u_long *' (aka 'unsigned long *') [-Werror,-Wincompatible-pointer-types]
TUNABLE_INT("kern.geom.journal.cache.limit", &g_journal_cache_limit);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@/sys/kernel.h:287:3: note: expanded from macro 'TUNABLE_INT'
                (var),                                          \
                ^~~~~
/usr/src/sys/modules/geom/geom_journal/../../../geom/journal/g_journal.c:178:14: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare]
        if (cswitch < 0 || cswitch > 100)
            ~~~~~~~ ^ ~

Could you help check this one?
https://ci.freebsd.org/job/FreeBSD-stable-10-amd64-build/1157/console

Thanks,
Li-Wen

-- 
Li-Wen Hsu <lwhsu at FreeBSD.org>
https://lwhsu.org