svn commit: r308371 - in stable/10: share/man/man4 sys/conf sys/dev/jedec_ts sys/modules/i2c sys/modules/i2c/jedec_ts
Andriy Gapon
avg at FreeBSD.org
Wed Dec 14 15:42:55 UTC 2016
On 05/12/2016 23:49, John Baldwin wrote:
> On Sunday, November 06, 2016 01:56:34 PM Andriy Gapon wrote:
>> Author: avg
>> Date: Sun Nov 6 13:56:34 2016
>> New Revision: 308371
>> URL: https://svnweb.freebsd.org/changeset/base/308371
>>
>> Log:
>> MFC r307768: jedec_ts: a driver for thermal sensors on memory modules
>>
>> Added:
>> stable/10/share/man/man4/jedec_ts.4
>> - copied unchanged from r307768, head/share/man/man4/jedec_ts.4
>> stable/10/sys/dev/jedec_ts/
>> - copied from r307768, head/sys/dev/jedec_ts/
>> stable/10/sys/modules/i2c/jedec_ts/
>> - copied from r307768, head/sys/modules/i2c/jedec_ts/
>> Modified:
>> stable/10/sys/conf/NOTES
>> stable/10/sys/conf/files
>> stable/10/sys/modules/i2c/Makefile
>> Directory Properties:
>> stable/10/ (props changed)
>
> FYI, this doesn't work and has broken tinderbox builds on stable/10.
> smbus_get_addr() doesn't exist on 10. It was originally a hand-rolled
> ivar wrapper that was removed in r93023 in 2002. The function prototype
> was not removed, so the compile works, but linking fails. The stale
> prototype is still present in smbconf.h in HEAD (and should be removed).
> The "real" smbus_get_addr() was added back to smbconf.h along with an
> implementation of smbus_read_ivar() in r281985. Parts of that commit
> probably need to be MFC'd to 10.
>
John,
thank you for catching this and sorry for the trouble.
Could you please check if r310062 really fixes the problem?
--
Andriy Gapon
More information about the svn-src-stable-10
mailing list