svn commit: r271707 - stable/10/sys/kern

[Alexander Motin]

On 17.09.2014 19:16, Andrey Chernov wrote:
> On 17.09.2014 18:06, Alexander Motin wrote:
>> +	/*
>> +	 * Make sure that tdq_load updated before calling this function
>> +	 * is globally visible before we read tdq_cpu_idle.  Idle thread
>> +	 * accesses both of them without locks, and the order is important.
>> +	 */
>> +	mb();
>> +
>>  	if (TD_IS_IDLETHREAD(ctd)) {
> 
> I don't understand this comment's first phrase with two verbs. Copy &
> paste result?

No, only possibly missing commas around "updated before calling this
function".

> I also don't see tdq_load access in this function.

It is incremented by tdq_load_add(), called by tdq_add(), called by
sched_add(), just before calling tdq_notify().

-- 
Alexander Motin