svn commit: r345563 - projects/fuse2/tests/sys/fs/fusefs

[Alan Somers]

On Tue, Mar 26, 2019 at 8:39 PM Enji Cooper <yaneurabeya at gmail.com> wrote:
>
>
> On Mar 26, 2019, at 5:24 PM, Alan Somers <asomers at FreeBSD.org> wrote:
>
> Author: asomers
> Date: Wed Mar 27 00:24:57 2019
> New Revision: 345563
> URL: https://svnweb.freebsd.org/changeset/base/345563
>
> Log:
>  fusefs: fix a race condition in the allow_other test
>
>  The test could occasionally hang if the parent's SIGUSR2 signal arrived
>  before the child had pause()d.  Using POSIX semaphores precludes that
>  possibility.
>
>  Sponsored by: The FreeBSD Foundation
>
>
> …
>
> + sem = (sem_t*)mmap(NULL, sizeof(*sem), mprot, mflags, -1, 0);
> + ASSERT_NE(NULL, sem) << strerror(errno);
>
>
> mmap will return “MAP_FAILED”, not NULL, on error.
>
> Thanks,
> -Enji

Whoops!  Good catch.