svn commit: r345415 - projects/capsicum-test/contrib/capsicum-test

Enji Cooper ngie at FreeBSD.org
Fri Mar 22 16:17:42 UTC 2019


Author: ngie
Date: Fri Mar 22 16:17:41 2019
New Revision: 345415
URL: https://svnweb.freebsd.org/changeset/base/345415

Log:
  Remove `FAIL` macro use for non-x86 architectures when testing `sysarch(2)`
  
  First off, `FAIL()` does not support being called in the form noted in the test.
  
  Second off, it's better to add a comment, open a bug, etc, instead of causing
  all test runs to fail on unsupported architectures.

Modified:
  projects/capsicum-test/contrib/capsicum-test/capmode.cc

Modified: projects/capsicum-test/contrib/capsicum-test/capmode.cc
==============================================================================
--- projects/capsicum-test/contrib/capsicum-test/capmode.cc	Fri Mar 22 14:49:22 2019	(r345414)
+++ projects/capsicum-test/contrib/capsicum-test/capmode.cc	Fri Mar 22 16:17:41 2019	(r345415)
@@ -558,8 +558,7 @@ FORK_TEST_F(WithFiles, AllowedMiscSyscalls) {
   long sysarch_arg = 0;
   EXPECT_CAPMODE(sysarch(I386_SET_IOPERM, &sysarch_arg));
 #else
-  // TOOD(jra): write a test for arm
-  FAIL("capmode:no sysarch() test for current architecture");
+  // TOOD(jra): write a test for other architectures, like arm
 #endif
 #endif
 }


More information about the svn-src-projects mailing list