svn commit: r344087 - in projects/import-googletest-1.8.1/lib/googletest: gmock/tests gtest/tests

[Rodney W. Grimes]

> On Feb 13, 2019, at 06:42, Rodney W. Grimes <freebsd at pdx.rh.cn85.dnsmgr.net> wrote:
> 
> >> On Feb 13, 2019, at 06:26, Rodney W. Grimes <freebsd at pdx.rh.cn85.dnsmgr.net> wrote:
> >> 
> >>>> Author: ngie
> >>>> Date: Wed Feb 13 05:41:04 2019
> >>>> New Revision: 344087
> >>>> URL: https://svnweb.freebsd.org/changeset/base/344087
> >>>> 
> >>>> Log:
> >>>> Compile the tests without -Werror for now
> >>>> 
> >>>> I'm working on resolving the issue upstream on github
> >>>> 
> >>>> Modified:
> >>>> projects/import-googletest-1.8.1/lib/googletest/gmock/tests/Makefile
> >>>> projects/import-googletest-1.8.1/lib/googletest/gtest/tests/Makefile
> >>> 
> >>> Are we going to have to live with this project name of
> >>> import-googletest-1.8.1 long term, or is this just a
> >>> stepping stone?
> >> 
> >> It?s a short lived project. I didn?t realize in the last year and a
> >> half that branch names had formalized into something else, especially
> >> since GUIDELINES.txt doesn?t state a naming convention.
> > 
> > I do not know that they have formalized in any way.  But as long
> > as it is shorted lived it really does not matter much.
> > 
> > Please do be careful when choosing a vendor/ directory name
> > if that is where this is headed, 'import' and '1.8.1' are
> > probably not wanted there at all, just googletest.
> 
> brooks reviewed my initial import into vendor to ensure that the
> naming/structure was correct: ^/vendor/google/googletest/dist ->
> ^/vendor/google/googletest/1.8.1 (for the release branch, given
> that the initial import was 1.8.1).
> 
> I?ve been following similar conventions before in the past
> other projects I?ve imported. Given that this is the first of a
> handful of google projects that will be imported, I don?t
> understand why there?s an issue with this naming convention.

There is no issue here, I did not raise an issue, I just asked if
that project was a short term thing, and wanted to make sure that
the long name was not copied into the vendor area, which you have not,
you have broken the long name up into its components as directories
as is the norm.

> -Enji
-- 
Rod Grimes                                                 rgrimes at freebsd.org