svn commit: r337605 - projects/bectl/lib/libbe

[Kyle Evans]

Author: kevans
Date: Sat Aug 11 04:09:42 2018
New Revision: 337605
URL: https://svnweb.freebsd.org/changeset/base/337605

Log:
  libbe(3): Document the import bug...

Modified:
  projects/bectl/lib/libbe/be.c
  projects/bectl/lib/libbe/libbe.3

Modified: projects/bectl/lib/libbe/be.c
==============================================================================
--- projects/bectl/lib/libbe/be.c	Sat Aug 11 04:07:00 2018	(r337604)
+++ projects/bectl/lib/libbe/be.c	Sat Aug 11 04:09:42 2018	(r337605)
@@ -696,7 +696,6 @@ be_import(libbe_handle_t *lbh, const char *bootenv, in
 	strftime(buf + len, BE_MAXPATHLEN - len,
 	    "@%F-%T", localtime(&rawtime));
 
-	/* lzc_receive(SNAPNAME, PROPS, ORIGIN, FORCE, fd)) { */
 	if ((err = lzc_receive(buf, NULL, NULL, false, fd)) != 0) {
 		switch (err) {
 		case EINVAL:
@@ -724,7 +723,8 @@ be_import(libbe_handle_t *lbh, const char *bootenv, in
 
 	nvlist_free(props);
 
-	return (be_destroy(lbh, nbuf, 0));
+	/* XXX TODO: Figure out how to destroy the ghost... */
+	return (BE_ERR_SUCCESS);
 }
 
 #if SOON

Modified: projects/bectl/lib/libbe/libbe.3
==============================================================================
--- projects/bectl/lib/libbe/libbe.3	Sat Aug 11 04:07:00 2018	(r337604)
+++ projects/bectl/lib/libbe/libbe.3	Sat Aug 11 04:09:42 2018	(r337605)
@@ -170,11 +170,9 @@ An error may occur if:
 .It libzfs fails to initialize,
 .It The system has not been properly booted with a ZFS boot
 environment,
-.It
-.Nm
+.It Nm
 fails to open the zpool the active boot environment resides on, or
-.It
-.Nm
+.It Nm
 fails to locate the boot environment that is currently mounted.
 .El
 .Pp
@@ -422,7 +420,6 @@ exactly as specified by
 The
 .Fn be_prop_list_free
 function will free the property list.
-.Fp
 .Sh DIAGNOSTICS
 Upon error, one of the following values will be returned.
 .\" TODO: make each entry on its own line.
@@ -458,5 +455,9 @@ were written as a 2017 Google Summer of Code project w
 as a mentor.
 Later work was done by
 .An Kyle Evans Aq Mt kevans at FreeBSD.org .
-.\" TODO: update when implementation complete.
-.\" .Sh BUGS
+.Sh BUGS
+The
+.Fn be_import
+function does not destroy the temporary boot environment it creates for import,
+because the snapshot created to do the import may not be deleted since it is the
+origin of the new boot environment.