svn commit: r302300 - projects/vnet/sys/netpfil/ipfw

[Bjoern A. Zeeb]

Author: bz
Date: Thu Jun 30 17:16:22 2016
New Revision: 302300
URL: https://svnweb.freebsd.org/changeset/base/302300

Log:
  In case of the global eventhandler make sure the current VNET
  is still operational before doing any work;  otherwise we might
  run into, e.g., released locks.
  
  PR:		210724
  Reported by:	olevole olevole.ru
  Sponsored by:	The FreeBSD Foundation

Modified:
  projects/vnet/sys/netpfil/ipfw/ip_fw_nat.c

Modified: projects/vnet/sys/netpfil/ipfw/ip_fw_nat.c
==============================================================================
--- projects/vnet/sys/netpfil/ipfw/ip_fw_nat.c	Thu Jun 30 15:04:03 2016	(r302299)
+++ projects/vnet/sys/netpfil/ipfw/ip_fw_nat.c	Thu Jun 30 17:16:22 2016	(r302300)
@@ -104,6 +104,10 @@ ifaddr_change(void *arg __unused, struct
 
 	KASSERT(curvnet == ifp->if_vnet,
 	    ("curvnet(%p) differs from iface vnet(%p)", curvnet, ifp->if_vnet));
+
+	if (V_ipfw_vnet_ready == 0 || V_ipfw_nat_ready == 0)
+		return;
+
 	chain = &V_layer3_chain;
 	IPFW_UH_WLOCK(chain);
 	/* Check every nat entry... */
@@ -1145,12 +1149,12 @@ vnet_ipfw_nat_uninit(const void *arg __u
 
 	chain = &V_layer3_chain;
 	IPFW_WLOCK(chain);
+	V_ipfw_nat_ready = 0;
 	LIST_FOREACH_SAFE(ptr, &chain->nat, _next, ptr_temp) {
 		LIST_REMOVE(ptr, _next);
 		free_nat_instance(ptr);
 	}
 	flush_nat_ptrs(chain, -1 /* flush all */);
-	V_ipfw_nat_ready = 0;
 	IPFW_WUNLOCK(chain);
 	return (0);
 }