svn commit: r288121 - projects/clang370-import/contrib/libc++/src/support

[Dimitry Andric]

On 22 Sep 2015, at 21:14, Ian Lepore <ian at FreeBSD.org> wrote:
> 
> On Tue, 2015-09-22 at 20:48 +0200, Dimitry Andric wrote:
>> On 22 Sep 2015, at 20:37, Warner Losh <imp at bsdimp.com> wrote:
...
>>> I’m not entirely sure that your ‘fix’ makes things actually safe, even if it
>>> seems to make them work today. I’ll have to study it more closely.
>> 
>> Probably not 100% safe, since the stub functions are just placeholders
>> which aren't atomic at all.
> 
> This is confusing.  The fact that these are stubs and aren't atomic at
> all is the problem.  There's no reason not to have real implementations
> on arm < v6, machine/atomic.h has all the common stuff implemented
> already.

They were not yet available in e.g. libgcc or libcompiler-rt, so I got
link errors when clang was emitting calls to e.g. __atomic_add_fetch().

Andy has now fixed this with r288125, so I can revert this crude
workaround. :-)

-Dimitry

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/svn-src-projects/attachments/20150922/446f24c4/attachment.bin>