svn commit: r290263 - projects/collation/contrib/netbsd-tests/lib/libc/locale

Baptiste Daroussin bapt at FreeBSD.org
Mon Nov 2 08:08:49 UTC 2015


On Mon, Nov 02, 2015 at 12:05:04AM -0800, NGie Cooper wrote:
> 
> > On Nov 1, 2015, at 23:59, Baptiste Daroussin <bapt at FreeBSD.org> wrote:
> > 
> > Author: bapt
> > Date: Mon Nov  2 07:59:17 2015
> > New Revision: 290263
> > URL: https://svnweb.freebsd.org/changeset/base/290263
> > 
> > Log:
> >  Fix regression test on multibytes
> > 
> >  0x07FF and 0x0800 are valid multibyte characters:
> >  'DOUBLE QUESTION MARK' and 'QUESTION EXCLAMATION MARK'
> > 
> > Modified:
> >  projects/collation/contrib/netbsd-tests/lib/libc/locale/t_mbstowcs.c
> > 
> > Modified: projects/collation/contrib/netbsd-tests/lib/libc/locale/t_mbstowcs.c
> > ==============================================================================
> > --- projects/collation/contrib/netbsd-tests/lib/libc/locale/t_mbstowcs.c	Mon Nov  2 07:46:47 2015	(r290262)
> > +++ projects/collation/contrib/netbsd-tests/lib/libc/locale/t_mbstowcs.c	Mon Nov  2 07:59:17 2015	(r290263)
> > @@ -87,7 +87,7 @@ static struct test {
> > 		0x5B, 0x01, 0x7F, 0x5D, 0x5B, 0x80, 0x07FF, 0x5D, 0x5B, 0x0800,
> > 		0xFFFF, 0x5D, 0x5B, 0x10000, 0x10FFFF, 0x5D, 0x0A
> > 	},
> > -	{	 1, -1, -1,  1,  1, -1, -1,  1,  1, -1, -1,  1,  1, -1, -1,
> > +	{	 1, -1, -1,  1,  1, -1, 1,  1,  1, 1, -1,  1,  1, -1, -1,
> > 		 1,  1, -1, -1,  1,  1, -1, -1,  1, -1
> 
> Please file an upstream PR for this (and any other failures you find) and if possible CC me.
> 
Sure I can do that

> I’ve been adding...
> 
> #ifdef __FreeBSD__
> /* FreeBSD-specific fix */
> #else
> /* Old code from NetBSD */
> #endif
> 
I can do that if you prefer
> … to track what needs to be upstreamed.

There is another one needed, but this time I think the regression test is right,
I'll dig a bit more.

Best regards,
Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-projects/attachments/20151102/af4a054b/attachment.bin>


More information about the svn-src-projects mailing list