svn commit: r274517 - projects/sendfile/sys/vm

[Gleb Smirnoff]

On Fri, Nov 14, 2014 at 10:17:35AM -0800, Garrett Cooper wrote:
G> > Log:
G> >  Use C99 "inline" keyword.
G> > 
G> > Modified:
G> >  projects/sendfile/sys/vm/vm_pager.h
G> > 
G> > Modified: projects/sendfile/sys/vm/vm_pager.h
G> > ==============================================================================
G> > --- projects/sendfile/sys/vm/vm_pager.h	Fri Nov 14 18:00:00 2014	(r274516)
G> > +++ projects/sendfile/sys/vm/vm_pager.h	Fri Nov 14 18:01:18 2014	(r274517)
G> > @@ -106,7 +106,7 @@ vm_object_t vm_pager_allocate(objtype_t,
G> > void vm_pager_bufferinit(void);
G> > void vm_pager_deallocate(vm_object_t);
G> > static __inline int vm_pager_get_pages(vm_object_t, vm_page_t *, int, int);
G> > -static __inline int vm_pager_get_pages_async(vm_object_t, vm_page_t *, int,
G> > +static inline int vm_pager_get_pages_async(vm_object_t, vm_page_t *, int,
G> >     int, void(*)(void *, int), void *);
G> > static __inline boolean_t vm_pager_has_page(vm_object_t, vm_pindex_t, int *, int *);
G> > void vm_pager_init(void);
G> > @@ -138,7 +138,7 @@ vm_pager_get_pages(
G> > 	return (r);
G> > }
G> 
G> - What was wrong with using the "non-C99" constant?

It was compiler keyword from XX century.

G> - Why not the other cases above that, e.g. vm_pager_get_pages?

Alan asks to avoid any style(9) changes to sys/vm, so that svn annotate
works. However, new code should be styled properly.

-- 
Totus tuus, Glebius.