svn commit: r248432 - in projects/counters/sys: kern sys

[Gleb Smirnoff]

Author: glebius
Date: Sun Mar 17 17:13:43 2013
New Revision: 248432
URL: http://svnweb.freebsd.org/changeset/base/248432

Log:
  Fixes to r248420:
  - Remove a check that never fires in sysctl_handle_counter_u64()
  - Add comment above SYSCTL_COUNTER_U64()
  
  Submitted by:	jilles

Modified:
  projects/counters/sys/kern/subr_counter.c
  projects/counters/sys/sys/sysctl.h

Modified: projects/counters/sys/kern/subr_counter.c
==============================================================================
--- projects/counters/sys/kern/subr_counter.c	Sun Mar 17 16:49:37 2013	(r248431)
+++ projects/counters/sys/kern/subr_counter.c	Sun Mar 17 17:13:43 2013	(r248432)
@@ -91,9 +91,6 @@ sysctl_handle_counter_u64(SYSCTL_HANDLER
 	if (error || !req->newptr)
 		return (error);
 
-	if (!arg1)
-		return (EPERM);
-
 	/*
 	 * Any write attempt to a counter zeroes it.
 	 */

Modified: projects/counters/sys/sys/sysctl.h
==============================================================================
--- projects/counters/sys/sys/sysctl.h	Sun Mar 17 16:49:37 2013	(r248431)
+++ projects/counters/sys/sys/sysctl.h	Sun Mar 17 17:13:43 2013	(r248432)
@@ -380,6 +380,7 @@ SYSCTL_ALLOWED_TYPES(UINT64, uint64_t *a
 	    SYSCTL_ADD_ASSERT_TYPE(UINT64, ptr), 0,			\
 	    sysctl_handle_64, "QU", __DESCR(descr))
 
+/* Oid for a 64-bin unsigned counter(9).  The pointer must be non NULL. */
 #define	SYSCTL_COUNTER_U64(parent, nbr, name, access, ptr, val, descr)	\
 	SYSCTL_ASSERT_TYPE(UINT64, ptr, parent, name);			\
 	SYSCTL_OID(parent, nbr, name,					\