svn commit: r254907 - projects/camlock/sys/geom
Alexander Motin
mav at FreeBSD.org
Mon Aug 26 12:18:52 UTC 2013
Author: mav
Date: Mon Aug 26 12:18:51 2013
New Revision: 254907
URL: http://svnweb.freebsd.org/changeset/base/254907
Log:
Move g_io_deliver() out of the lock, as required for direct dispatch.
Move g_destroy_bio() out too to reduce lock scope even more.
Modified:
projects/camlock/sys/geom/geom_disk.c
Modified: projects/camlock/sys/geom/geom_disk.c
==============================================================================
--- projects/camlock/sys/geom/geom_disk.c Mon Aug 26 12:05:38 2013 (r254906)
+++ projects/camlock/sys/geom/geom_disk.c Mon Aug 26 12:18:51 2013 (r254907)
@@ -246,13 +246,14 @@ g_disk_done(struct bio *bp)
bp2->bio_completed += bp->bio_completed;
if ((bp->bio_cmd & (BIO_READ|BIO_WRITE|BIO_DELETE)) != 0)
devstat_end_transaction_bio_bt(sc->dp->d_devstat, bp, &now);
- g_destroy_bio(bp);
bp2->bio_inbed++;
if (bp2->bio_children == bp2->bio_inbed) {
+ mtx_unlock(&sc->done_mtx);
bp2->bio_resid = bp2->bio_bcount - bp2->bio_completed;
g_io_deliver(bp2, bp2->bio_error);
- }
- mtx_unlock(&sc->done_mtx);
+ } else
+ mtx_unlock(&sc->done_mtx);
+ g_destroy_bio(bp);
}
static int
More information about the svn-src-projects
mailing list