svn commit: r240747 - projects/amd64_xen_pv/sys/dev/xen/netback

Cherry G. Mathew cherry at FreeBSD.org
Thu Sep 20 14:52:51 UTC 2012


Author: cherry
Date: Thu Sep 20 14:52:50 2012
New Revision: 240747
URL: http://svn.freebsd.org/changeset/base/240747

Log:
  Alter file scoped macro semantics to fit usecases, in order to fix
  build on llvm.
  
  An alternate fix would have been an inline private function instead,
  but given that there are no consumers of the return value of the
  expression - Occam's Razor was applied.
  
  Reported by Bret Ketchum <Bret_Ketchum at DELL.com>.

Modified:
  projects/amd64_xen_pv/sys/dev/xen/netback/netback_unit_tests.c

Modified: projects/amd64_xen_pv/sys/dev/xen/netback/netback_unit_tests.c
==============================================================================
--- projects/amd64_xen_pv/sys/dev/xen/netback/netback_unit_tests.c	Thu Sep 20 14:38:21 2012	(r240746)
+++ projects/amd64_xen_pv/sys/dev/xen/netback/netback_unit_tests.c	Thu Sep 20 14:52:50 2012	(r240747)
@@ -58,8 +58,8 @@ __FBSDID("$FreeBSD$");
 #define	TOSTRING(x) STRINGIFY(x)
 
 /**
- * Writes an error message to buffer if cond is false, and returns true
- * iff the assertion failed.  Note the implied parameters buffer and
+ * Writes an error message to buffer if cond is false
+ * Note the implied parameters buffer and
  * buflen
  */
 #define	XNB_ASSERT(cond) ({						\
@@ -71,7 +71,7 @@ __FBSDID("$FreeBSD$");
 		strlcat(_buffer, ":" TOSTRING(__LINE__) 		\
 		  " Assertion Error: " #cond "\n", _buflen);		\
 	}								\
- ! passed; })
+        })
 
 
 /**


More information about the svn-src-projects mailing list