svn commit: r238907 - projects/calloutng/sys/kern

Attilio Rao attilio at freebsd.org
Tue Sep 18 15:30:59 UTC 2012


On 9/18/12, Konstantin Belousov <kostikbel at gmail.com> wrote:
> On Tue, Sep 18, 2012 at 01:13:08AM +0100, Attilio Rao wrote:
>> diff --git a/sys/sys/cdefs.h b/sys/sys/cdefs.h
>> index 8224672..fc6a75f 100644
>> --- a/sys/sys/cdefs.h
>> +++ b/sys/sys/cdefs.h
>> @@ -114,6 +114,13 @@
>>  #endif
>>
>>  /*
>> + * Compiler memory barriers, specific to gcc and clang.
>> + */
>> +#if defined(__GNUC__)
>> +#define        __compiler_membar()     __asm __volatile(" " : : :
>> "memory")
>> +#endif
>> +
>> +/*
>
> Traditionally, we do provide the fallback for non-GNUC compilers, by
> defining extern function with the compatible signature. In this case,
> the empty function just works for the purpose, although with higher
> overhead than the GNUC case.

I agree, we need a fallback here. Unfortunately I'm buried with job
stuff but I will provide an errata patch ASAP.

Thanks,
Attilio


-- 
Peace can only be achieved by understanding - A. Einstein


More information about the svn-src-projects mailing list