svn commit: r236554 - projects/pf/head/sys/contrib/pf/net

Gleb Smirnoff glebius at FreeBSD.org
Mon Jun 4 13:34:01 UTC 2012


On Mon, Jun 04, 2012 at 09:29:46PM +1000, Bruce Evans wrote:
B> > Log:
B> >  Consistent names for pf(4) malloc(9) types.
B> 
B> Many still have spaces in them.  This breaks at least simple parsing
B> of "vmstat -m" output using columns in awk (and postprocessing of
B> vmstat -m output is more needed than orginally, since vmstat is now
B> too stupid to even print the totals).  A few bugs in this area have
B> been fixed relatively recently.  For example:
B> 
B>    file desc -> filedesc   (matches original naming scheme -- no underscore)
B>    BIO buffer -> biobuf
B>    UFS mount -> ufs_mount  (now just a style bug -- underscore)
B>    VM pgdata -> vm_pgdata
B>    * ihash -> [went away]
B>    struct cdev * -> [went away]
B>    cluster_save buffer -> [went away]  (was also too long)
B>    [too many] -> [vmstat -z, with worse names and formatting]

Should only the shortdesc not contain spaces? Well, there is conflict between
parseability and understandability :)

B> Now broken on ref10-i386:
B> 
B>    NFSCL diroffd
B>    NFS fh
B> 
B> only.

Also a lot of "CAM foo".

-- 
Totus tuus, Glebius.


More information about the svn-src-projects mailing list