svn commit: r235672 - in projects/arm_eabi/sys: amd64/include i386/include ia64/include mips/include pc98/include powerpc/include sparc64/include x86/include

Andrew Turner andrew at fubar.geek.nz
Sun Jun 3 02:35:48 UTC 2012


On Sun, 20 May 2012 18:58:12 +1000 (EST)
Bruce Evans <brde at optusnet.com.au> wrote:

> On Sat, 19 May 2012, Andrew Turner wrote:
> 
> > Log:
> >  Fix wchar support in the not ARM case.
> >
> >   * Add machine/_wchar.h to define WCHAR_{MIN,MAX} and include it
> > from machine/_stdint.h, it is already in wchar.h.
> 
> This adds 2 layers of include pessimizations to x86, though only 1
> layer to other arches.  The pessimization is most noticeable over
> nfs, where the RPCs for reopening include files can take 10-100 times
> longer than actually reading and parsing of the files for small files.
> 
> This has some style bugs.
> 
> >   * Add the typedef for __wchar_t to machine/_types.h.
> 
> The limits should be defined (with leading underscores) here too, so
> that no new includes are needed.

How about the attached patch? It:
 * Removes machine/_wchar.h.
 * Moves the __wchar_t typedef to machine/_types.h.
 * Adds __WCHAR_MIN and __WCHAR_MAX to machine/_types.h and uses them where required.

This is against head and only for sparc64. I will do the same on the
other architectures.

Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sparc64_wchar.diff
Type: text/x-patch
Size: 1748 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/svn-src-projects/attachments/20120603/1ace5a45/sparc64_wchar.bin


More information about the svn-src-projects mailing list