svn commit: r244249 - projects/calloutng/sys/dev/syscons

[Alexander Motin]

On 17.12.2012 22:09, John Baldwin wrote:
> On Saturday, December 15, 2012 5:44:16 am Alexander Motin wrote:
>> Author: mav
>> Date: Sat Dec 15 10:44:16 2012
>> New Revision: 244249
>> URL: http://svnweb.freebsd.org/changeset/base/244249
>>
>> Log:
>>    Switch syscons from timeout() to callout_reset_flags() and specify that
>>    precision is not important there -- anything from 20 to 30Hz will be fine.
>>
>> Modified:
>>    projects/calloutng/sys/dev/syscons/syscons.c
>>    projects/calloutng/sys/dev/syscons/syscons.h
>>
>> Modified: projects/calloutng/sys/dev/syscons/syscons.c
>>
> ==============================================================================
>> --- projects/calloutng/sys/dev/syscons/syscons.c	Sat Dec 15 10:30:06 2012	
> (r244248)
>> +++ projects/calloutng/sys/dev/syscons/syscons.c	Sat Dec 15 10:44:16 2012	
> (r244249)
>> @@ -504,6 +504,8 @@ sc_attach_unit(int unit, int flags)
>>
>>       sc = sc_get_softc(unit, flags & SC_KERNEL_CONSOLE);
>>       sc->config = flags;
>> +    callout_init(&sc->ctimeout, FALSE);
>> +    callout_init(&sc->cblink, FALSE);
>
> Did you change the calling conventions for callout_init() in this branch?  In
> HEAD the second argument is a flags variable (albeit with only a single flag
> defined: CALLOUT_MPSAFE).  Thus, the common usage is to use 'callout_init(..,
> 0);' for callouts that need Giant and 'callout_init(..., CALLOUT_MPSAFE);' for
> those that do not need Giant.

No, I haven't. But man page still talks about "FALSE" value for mpsafe 
argument and that confused me. Fixed. Thanks.

-- 
Alexander Motin