svn commit: r211029 - projects/sv/sys/net

[Ed Maste]

On Sun, Aug 08, 2010 at 02:35:53PM +0200, Attilio Rao wrote:

> 2010/8/8 Ed Maste <emaste at freebsd.org>:
> > On Sat, Aug 07, 2010 at 05:39:22PM +0000, Attilio Rao wrote:
> >
> >> Author: attilio
> >> Date: Sat Aug ??7 17:39:22 2010
> >> New Revision: 211029
> >> URL: http://svn.freebsd.org/changeset/base/211029
> >>
> >> Log:
> >> ?? Add a tunable for nd_enable.
> >> ?? As long as TUNABLE_INT is discouraged, however, switch the type int -> long
> >> ?? and adjust accordingly the sysctl stubs.
> >
> > This doesn't really make sense as far as I can tell - and particularly
> > for sysctls, using a long can introduce 32-bit compat issues. ??I'd
> > prefer that this remain an int.
> >
> > What benefit does using a long provide in this case?
> 
> Did you see the recent thread on hackers@ about it?
> If we choice to go with a direction on TUNABLES_* I'd prefer to follow it now.

I just read it now, but I don't see any actual reason to prefer long in
that thread.

-Ed