svn commit: r362361 - in head/sys: compat/linuxkpi/common/src vm

[Hans Petter Selasky]

On 2020-06-19 05:32, Mark Johnston wrote:
> +++ head/sys/vm/vm_map.h	Fri Jun 19 03:32:04 2020	(r362361)
> @@ -255,6 +255,17 @@ vm_map_modflags(vm_map_t map, vm_flags_t set, vm_flags
>   {
>   	map->flags = (map->flags | set) & ~clear;
>   }
> +
> +static inline bool
> +vm_map_range_valid(vm_map_t map, vm_offset_t start, vm_offset_t end)
> +{

Hi Mark,

Don't you also need to add:

#define vm_map_range_valid(map, start, end)        vm_map_pmap_KBI(map, 
start, end)

And implement the _KBI function?

Building the LinuxKPI from the command line is now broken:

> env CC=`which clang10` make -m $PWD/share/mk/ -C sys/modules/linuxkpi/ 
> /usr/local/bin/clang10  -O2 -pipe -fno-common  -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc  -I/usr/img/freebsd.12/sys/compat/linuxkpi/common/include -I/usr/img/freebsd.12/sys/contrib/ck/include -I. -I/usr/img/freebsd.12/sys -I/usr/img/freebsd.12/sys/contrib/ck/include -fno-common  -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fdebug-prefix-map=./machine=/usr/img/freebsd.12/sys/amd64/include -fdebug-prefix-map=./x86=/usr/img/freebsd.12/sys/x86/include   -MD  -MF.depend.linux_page.o -MTlinux_page.o -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float  -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error-tautological-compare -Wno-error-empty-body -Wno-error-parentheses-equality -Wno-error-unused-function -Wno-error-pointer-sign -Wno-error-shift-negative-value -Wno-address-of-packed-member  -mno-aes -mno-avx  -std=iso9899:1999 -c /usr/img/freebsd.12/sys/compat/linuxkpi/common/src/linux_page.c -o linux_page.o
> /usr/img/freebsd.12/sys/compat/linuxkpi/common/src/linux_page.c:237:7: error: implicit declaration of function 'vm_map_range_valid' is invalid in
>       C99 [-Werror,-Wimplicit-function-declaration]
>         if (!vm_map_range_valid(map, start, end))
>              ^
> 1 error generated.
> *** Error code 1

--HPS