svn commit: r363122 - head/sys/dev/extres/clk

Michal Meloun mmel at FreeBSD.org
Sun Jul 12 07:42:22 UTC 2020


Author: mmel
Date: Sun Jul 12 07:42:21 2020
New Revision: 363122
URL: https://svnweb.freebsd.org/changeset/base/363122

Log:
   Assigned clocks: fix off-by-one bug, don't leak allocated memory.
  
   MFC after:	1 week

Modified:
  head/sys/dev/extres/clk/clk.c

Modified: head/sys/dev/extres/clk/clk.c
==============================================================================
--- head/sys/dev/extres/clk/clk.c	Sun Jul 12 07:27:21 2020	(r363121)
+++ head/sys/dev/extres/clk/clk.c	Sun Jul 12 07:42:21 2020	(r363122)
@@ -1420,15 +1420,17 @@ clk_set_assigned(device_t dev, phandle_t node)
 		}
 
 		/* First set it's parent if needed */
-		if (i <= nparents)
+		if (i < nparents)
 			clk_set_assigned_parent(dev, clk, i);
 
 		/* Then set a new frequency */
-		if (i <= nrates && rates[i] != 0)
+		if (i < nrates && rates[i] != 0)
 			clk_set_assigned_rates(dev, clk, rates[i]);
 
 		clk_release(clk);
 	}
+	if (rates != NULL)
+		OF_prop_free(rates);
 
 	return (0);
 }


More information about the svn-src-head mailing list