svn commit: r358416 - head/sys/sys
Ian Lepore
ian at freebsd.org
Fri Feb 28 21:27:46 UTC 2020
On Fri, 2020-02-28 at 21:16 +0000, Brooks Davis wrote:
> On Fri, Feb 28, 2020 at 01:02:02AM +0000, Warner Losh wrote:
> > Author: imp
> > Date: Fri Feb 28 01:02:01 2020
> > New Revision: 358416
> > URL: https://svnweb.freebsd.org/changeset/base/358416
> >
> > Log:
> > Remove duplicated ATA_CHECK_POWER_MODE
> >
> > Modified:
> > head/sys/sys/ata.h
> >
> > Modified: head/sys/sys/ata.h
> > ===================================================================
> > ===========
> > --- head/sys/sys/ata.h Fri Feb 28 00:42:27 2020 (r358415)
> > +++ head/sys/sys/ata.h Fri Feb 28 01:02:01 2020 (r358416)
> > @@ -507,7 +507,6 @@ struct ata_params {
> > #define ATA_SF_DIS_SRVIRQ 0xde /* disable service
> > interrupt */
> > #define ATA_SF_LPSAERC 0x62 /* Long Phys Sect
> > Align ErrRep*/
> > #define ATA_SF_DSN 0x63 /* Device Stats
> > Notification */
> > -#define ATA_CHECK_POWER_MODE 0xe5 /* Check
> > Power Mode */
> > #define ATA_SECURITY_SET_PASSWORD 0xf1 /* set drive
> > password */
> > #define ATA_SECURITY_UNLOCK 0xf2 /* unlock drive
> > using passwd */
> > #define ATA_SECURITY_ERASE_PREPARE 0xf3 /* prepare to
> > erase drive */
> >
>
> I know that's not that you were working on, but that's a remarkable
> collection of whitespace decisions in the remaining lines.
>
> -- Brooks
It's not as bad when you open the file in an editor. The indentation
is consistent and sensible, but it contains a mix of spaces and tabs so
it looks pretty bad in an email diff.
-- Ian
More information about the svn-src-head
mailing list