svn commit: r368519 - in head: sys/dev/bvm usr.sbin/bhyve

[Robert Wing]

Author: rew
Date: Thu Dec 10 18:07:25 2020
New Revision: 368519
URL: https://svnweb.freebsd.org/changeset/base/368519

Log:
  Add deprecation notice for bvmconsole and bvmdebug
  
  Now that bhyve(8) supports UART, bvmconsole and bvmdebug are no longer needed.
  
  Mark the '-b' and '-g' flag as deprecated for bhyve(8).
  
  These will be removed in 13.
  
  Reviewed by:    jhb, grehan
  Approved by:    kevans (mentor)
  MFC after:      1 week
  Differential Revision:  https://reviews.freebsd.org/D27519

Modified:
  head/sys/dev/bvm/bvm_console.c
  head/sys/dev/bvm/bvm_dbg.c
  head/usr.sbin/bhyve/bhyve.8
  head/usr.sbin/bhyve/bhyverun.c

Modified: head/sys/dev/bvm/bvm_console.c
==============================================================================
--- head/sys/dev/bvm/bvm_console.c	Thu Dec 10 17:48:34 2020	(r368518)
+++ head/sys/dev/bvm/bvm_console.c	Thu Dec 10 18:07:25 2020	(r368519)
@@ -107,6 +107,8 @@ static void
 cn_drvinit(void *unused)
 {
 	struct tty *tp;
+    
+	gone_in(13, "bvmconsole");
 
 	if (bvm_consdev.cn_pri != CN_DEAD) {
 		tp = tty_alloc(&bvm_ttydevsw, NULL);

Modified: head/sys/dev/bvm/bvm_dbg.c
==============================================================================
--- head/sys/dev/bvm/bvm_dbg.c	Thu Dec 10 17:48:34 2020	(r368518)
+++ head/sys/dev/bvm/bvm_dbg.c	Thu Dec 10 18:07:25 2020	(r368519)
@@ -61,6 +61,8 @@ bvm_dbg_probe(void)
 	disabled = 0;
 	resource_int_value("bvmdbg", 0, "disabled", &disabled);
 
+	gone_in(13, "bvmdebug");
+
 	if (!disabled) {
 		if (resource_int_value("bvmdbg", 0, "port", &port) == 0)
 			bvm_dbg_port = port;

Modified: head/usr.sbin/bhyve/bhyve.8
==============================================================================
--- head/usr.sbin/bhyve/bhyve.8	Thu Dec 10 17:48:34 2020	(r368518)
+++ head/usr.sbin/bhyve/bhyve.8	Thu Dec 10 18:07:25 2020	(r368519)
@@ -24,7 +24,7 @@
 .\"
 .\" $FreeBSD$
 .\"
-.Dd Jun 25, 2020
+.Dd December 8, 2020
 .Dt BHYVE 8
 .Os
 .Sh NAME
@@ -104,7 +104,8 @@ Enable a low-level console device supported by
 .Fx
 kernels compiled with
 .Cd "device bvmconsole" .
-This option will be deprecated in a future version.
+This option is deprecated and will be removed in
+.Fx 13.0 .
 .It Fl c Op Ar setting ...
 Number of guest virtual CPUs
 and/or the CPU topology.
@@ -145,7 +146,8 @@ kernels compiled with
 .Cd "device bvmdebug" ,
 allow a remote kernel kgdb to be relayed to the guest kernel gdb stub
 via a local IPv4 address and this port.
-This option will be deprecated in a future version.
+This option is deprecated and will be removed in
+.Fx 13.0 .
 .It Fl G Ar port
 Start a debug server that uses the GDB protocol to export guest state to a
 debugger.

Modified: head/usr.sbin/bhyve/bhyverun.c
==============================================================================
--- head/usr.sbin/bhyve/bhyverun.c	Thu Dec 10 17:48:34 2020	(r368518)
+++ head/usr.sbin/bhyve/bhyverun.c	Thu Dec 10 18:07:25 2020	(r368519)
@@ -1124,6 +1124,7 @@ main(int argc, char *argv[])
 			acpi = 1;
 			break;
 		case 'b':
+			warnx("-b flag is deprecated and will be removed in FreeBSD 13.0");
 			bvmcons = 1;
 			break;
 		case 'D':
@@ -1145,6 +1146,7 @@ main(int argc, char *argv[])
 			memflags |= VM_MEM_F_INCORE;
 			break;
 		case 'g':
+			warnx("-g flag is deprecated and will be removed in FreeBSD 13.0");
 			dbg_port = atoi(optarg);
 			break;
 		case 'G':