svn commit: r348998 - head/usr.sbin/bhyve

John Baldwin jhb at FreeBSD.org
Wed Jun 12 16:49:02 UTC 2019


Author: jhb
Date: Wed Jun 12 16:49:01 2019
New Revision: 348998
URL: https://svnweb.freebsd.org/changeset/base/348998

Log:
  Remove a spurious break when setting up a 64-bit memory BAR.
  
  This was causing 'enbit' to not be initialized in this case.
  
  CID:		1401924
  Reported by:	Coverity
  MFC after:	1 week

Modified:
  head/usr.sbin/bhyve/pci_emul.c

Modified: head/usr.sbin/bhyve/pci_emul.c
==============================================================================
--- head/usr.sbin/bhyve/pci_emul.c	Wed Jun 12 16:34:02 2019	(r348997)
+++ head/usr.sbin/bhyve/pci_emul.c	Wed Jun 12 16:49:01 2019	(r348998)
@@ -634,7 +634,6 @@ pci_emul_alloc_pbar(struct pci_devinst *pdi, int idx, 
 			mask = PCIM_BAR_MEM_BASE;
 			lobits = PCIM_BAR_MEM_SPACE | PCIM_BAR_MEM_64 |
 				 PCIM_BAR_MEM_PREFETCH;
-			break;
 		} else {
 			baseptr = &pci_emul_membase32;
 			limit = PCI_EMUL_MEMLIMIT32;


More information about the svn-src-head mailing list