svn commit: r335629 - in head: share/man/man4 sys/dev/vt/hw/vga

[Roger Pau Monné]

On Tue, Jun 26, 2018 at 05:21:27AM +0000, Alexey Dokuchaev wrote:
> On Mon, Jun 25, 2018 at 08:43:51AM -0700, Rodney W. Grimes wrote:
> > > New Revision: 335629
> > > URL: https://svnweb.freebsd.org/changeset/base/335629
> > > 
> > > Log:
> > >   vt: add option to ignore NO_VGA flag in ACPI
> > >   
> > >   To workaround buggy firmware that sets this flag when there's actually
> > >   a VGA present.
> > >   
> > >   Reported and tested by:	Yasuhiro KIMURA <yasu at utahime.org>
> > >   Sponsored by:		Citrix Systems R&D
> > >   Reviewed by:		kib
> > >   Differential revision:	https://reviews.freebsd.org/D16003
> > 
> > It is generally best to avoid double negatives,
> > couldnt this of been better named? (hw.vga.acpi_force_vga)
> 
> Yes please; I get constantly confused when calculating negatives and
> often get them wrong.

This is specifically done to workaround a firmware bug where some
buggy firmwares set the NO_VGA flag in ACPI. So the option does
exactly what the name says, it ignores the NO_VGA flag in ACPI. IMO
acpi_force_vga is not as descriptive as the current name.

Roger.