svn commit: r335091 - head/sbin/nvmecontrol [broke builds of FreeBSD-head-armv7-build and other 32-bit ci.freeb sd.org builds]

[Mark Millard]

Warner Losh imp at FreeBSD.org wrote on
Wed Jun 13 22:00:04 UTC 2018  :

> Author: imp
> Date: Wed Jun 13 22:00:02 2018
> New Revision: 335091
> URL: 
> https://svnweb.freebsd.org/changeset/base/335091
> 
> 
> Log:
>   Make it possible to use print_controller from another program
>   
>   Rename print_controller to nvme_print_controller. Put it in its
>   own file for easy inclusion. Move util.c to be nc_util.c to not
>   conflict with camcontrol. add nvecontrol_ext.h to define shared
>   interfaces.
>   
>   Sponsored by: Netflix
>   Differential Revision: 
> https://reviews.freebsd.org/D15371
> 
> 
> Added:
>   head/sbin/nvmecontrol/identify_ext.c
>      - copied, changed from r335089, head/sbin/nvmecontrol/identify.c
>   head/sbin/nvmecontrol/nc_util.c
>      - copied, changed from r335089, head/sbin/nvmecontrol/util.c
>   head/sbin/nvmecontrol/nvmecontrol_ext.h   (contents, props changed)
>      - copied, changed from r335089, head/sbin/nvmecontrol/util.c
> Deleted:
>   head/sbin/nvmecontrol/util.c
> Modified:
>   head/sbin/nvmecontrol/Makefile
>   head/sbin/nvmecontrol/identify.c
. . .


For 32-bit clang-based targets first . . .

FreeBSD-head-armv7-build
FreeBSD-head-armv6-build

get build failures like:

--- all_subdir_sbin ---
In file included from /usr/src/sbin/nvmecontrol/identify_ext.c:43:
/usr/src/sbin/nvmecontrol/nvmecontrol.h:112:9: error: unknown type name '__uint128_t'
typedef __uint128_t uint128_t;
        ^
1 error generated.
*** [identify_ext.o] Error code 1


For 32-bit gcc 4.2.1 targets second . . .

FreeBSD-head-mips-build
FreeBSD-head-powerpc-build
FreeBSD-head-powerpcspe-build

get build failures like:

--- all_subdir_sbin ---
In file included from /usr/src/sbin/nvmecontrol/identify_ext.c:43:
/usr/src/sbin/nvmecontrol/nvmecontrol.h:112: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'uint128_t'
/usr/src/sbin/nvmecontrol/nvmecontrol.h:116: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'to128'
/usr/src/sbin/nvmecontrol/nvmecontrol.h:122: error: expected ')' before 'u'
cc1: warnings being treated as errors
/usr/src/sbin/nvmecontrol/identify_ext.c: In function 'nvme_print_controller':
/usr/src/sbin/nvmecontrol/identify_ext.c:219: warning: implicit declaration of function 'uint128_to_str'
/usr/src/sbin/nvmecontrol/identify_ext.c:219: warning: nested extern declaration of 'uint128_to_str'
/usr/src/sbin/nvmecontrol/identify_ext.c:219: warning: implicit declaration of function 'to128'
/usr/src/sbin/nvmecontrol/identify_ext.c:219: warning: nested extern declaration of 'to128'
/usr/src/sbin/nvmecontrol/identify_ext.c:219: warning: format '%s' expects type 'char *', but argument 2 has type 'int'
/usr/src/sbin/nvmecontrol/identify_ext.c:221: warning: format '%s' expects type 'char *', but argument 2 has type 'int'
*** [identify_ext.o] Error code 1




===
Mark Millard
marklmi at yahoo.com
( dsl-only.net went
away in early 2018-Mar)