svn commit: r335888 - in head: contrib/blacklist/bin lib/libpjdlog sbin/hastd

[Ruslan Bukin]

On Tue, Jul 03, 2018 at 08:21:58AM -0700, John Baldwin wrote:
> On 7/3/18 8:02 AM, Ruslan Bukin wrote:
> > On Tue, Jul 03, 2018 at 07:57:00AM -0700, John Baldwin wrote:
> >> On 7/3/18 6:53 AM, Ruslan Bukin wrote:
> >>> Author: br
> >>> Date: Tue Jul  3 13:53:54 2018
> >>> New Revision: 335888
> >>> URL: https://svnweb.freebsd.org/changeset/base/335888
> >>>
> >>> Log:
> >>>   o Ensure va_list is declared by including stdarg.h.
> >>>   o Also move printf.h to go after it since it does require declaration
> >>>     of va_list.
> >>>   
> >>>   This fixes build with latest RISC-V GNU Toolchain with GCC 8.1
> >>
> >> Normal style(9) is to sort headers.  Also, <printf.h> includes <stdio.h> already
> >> so should already have va_list defined.  I think there is some other build problem
> >> you are running into with GCC 8.1.  Did you ensure you stripped all of the
> >> 'include-fixed' headers when you updated riscv64-gcc?  This seems to be an issue
> >> of busted headers in the compiler and these changes should probably be reverted.
> >>
> > 
> > What do you mean stripped? Should I do something with this directory
> 
> The xtoolchain ports and base/gcc remove these entirely since GCC usually breaks
> them.  You can just remove that directory if you are building by hand.
> 

It works. Thanks!

Ruslan