svn commit: r324415 - in head/sys: kern sys

[John Baldwin]

On Sunday, October 08, 2017 11:56:30 AM Ian Lepore wrote:
> On Sun, 2017-10-08 at 17:33 +0000, Ian Lepore wrote:
> > Author: ian
> > Date: Sun Oct  8 17:33:49 2017
> > New Revision: 324415
> > URL: https://svnweb.freebsd.org/changeset/base/324415
> > 
> > Log:
> >   Add eventhandler notifications for newbus device attach/detach.
> >   
> > [...]
> >   
> >   A couple salient comments from the review, they amount to some helpful
> >   documentation about these events, but there's currently no good place for
> >   such documentation...
> 
> About this last point... sys/eventhandler.h is now an ever-growing list
> of EVENTHANDLER_DECLARE() statements for events that are unrelated to
> each other.  I think we are at the point where it's no longer a few
> well-known "standard system event queues", it's turning into a mess.
> 
> My first thought was to add these to bus.h because they're bus events.
>  But you have to include eventhandler.h to use EVENTHANDLER_DECLARE,
> and I didn't want to pull it (and its dependencies) into bus.h.

I think we should fix the headers so that we can declare these in bus.h.
It might consist of moving some bits of eventhandler.h into _eventhandler.h.
All you would need for _eventhandler.h is struct eventhandler_entry and
EVENTHANDLER_DECLARE() I think.

-- 
John Baldwin