svn commit: r317755 - head/sbin/ifconfig

[Warner Losh]

On Wed, May 3, 2017 at 1:38 PM, Alan Somers <asomers at freebsd.org> wrote:
> On Wed, May 3, 2017 at 1:34 PM, Warner Losh <imp at bsdimp.com> wrote:
>> On Wed, May 3, 2017 at 1:32 PM, Alan Somers <asomers at freebsd.org> wrote:
>>> On Wed, May 3, 2017 at 12:16 PM, Ngie Cooper <yaneurabeya at gmail.com> wrote:
>>>>
>>>>> On May 3, 2017, at 10:21, Alan Somers <asomers at FreeBSD.org> wrote:
>>>>>
>>>>> Author: asomers
>>>>> Date: Wed May  3 17:21:01 2017
>>>>> New Revision: 317755
>>>>> URL: https://svnweb.freebsd.org/changeset/base/317755
>>>>>
>>>>> Log:
>>>>>  Various Coverity fixes in ifconfig(8)
>>>>
>>>> ...
>>>>
>>>>>  * Mark usage() as _Noreturn (1305806, 1305750)
>>>>
>>>> ...
>>>>
>>>>> -static    void usage(void);
>>>>> +static    void usage(void) _Noreturn;
>>>>
>>>> Hi Alan,
>>>>     Please use __dead2 instead to be consistent with legacy use of similar gcc attributes.
>>>> Thanks,
>>>> -Ngie
>>>
>>> Why not use _Noreturn?  It's standardized by C11, so tools understand
>>> it better than __dead2.
>>
>> Tools that can't understand #define __dead2 _Noreturn aren't worth supporting.
>>
>> Warner
>
> Some tools don't expand preprocessor macros.  Like my editor, for
> example, which highlights _Noreturn as a keyword but not __dead2.

"My editor is lame" isn't a good reason. However,

% grep _Noreturn /usr/include/sys/cdefs.h
#define _Noreturn __dead2

"Because it works, does the right thing and is standardized" is a much
better reason. I hadn't checked to make sure that this was the case,
but since it is, I think you did the right thing.

Warner