svn commit: r314142 - head/sys/dev/ce
Alexey Dokuchaev
danfe at FreeBSD.org
Fri Feb 24 03:05:46 UTC 2017
On Thu, Feb 23, 2017 at 12:49:01PM -0500, Pedro Giffuni wrote:
> On 2/23/2017 12:13 PM, Benjamin Kaduk wrote:
> > On Thu, Feb 23, 2017 at 9:30 AM, Pedro F. Giffuni <pfg at freebsd.org
> > <mailto:pfg at freebsd.org>> wrote:
> > @@ -632,8 +632,8 @@ void ce_stop_chan (ce_chan_t *c)
> > "UserRequest (%s:%d)\n",
> > __FUNCTION__, __LINE__));
> > return;
> > }
> > - req->Command = TAU32_Configure_Commit |
> > - TAU32_Tx_Stop | TAU32_Rx_Stop;
> > +// req->Command = TAU32_Configure_Commit |
> > +// TAU32_Tx_Stop | TAU32_Rx_Stop;
> >
> > Should probably stick to C-style comments, though.
>
> They are valid C99 comments but I understand what you mean,
Using comments (regardless of style) for disabling a code block is wrong;
may I suggest `#if 0' instead? (This also does not hurt `svn blame'.)
./danfe
More information about the svn-src-head
mailing list