svn commit: r314145 - in head/sys/dev/vxge: . vxgehal

Pedro Giffuni pfg at FreeBSD.org
Thu Feb 23 19:01:10 UTC 2017



On 02/23/17 13:16, John Baldwin wrote:
> On Thursday, February 23, 2017 04:10:16 PM Pedro F. Giffuni wrote:
>> Author: pfg
>> Date: Thu Feb 23 16:10:15 2017
>> New Revision: 314145
>> URL: https://svnweb.freebsd.org/changeset/base/314145
>>
>> Log:
>>   dev/vxe: double assignments.
>>
>>   Fix some suspicious code, likely caused by excessive copy-pasting.
>>
>>   Found with:	coccinelle (da.cocci)
>>   MFC after:	2 weeks
>>
>> Modified:
>>   head/sys/dev/vxge/vxge.c
>>   head/sys/dev/vxge/vxgehal/vxgehal-config.c
>>
>> Modified: head/sys/dev/vxge/vxge.c
>> ==============================================================================
>> --- head/sys/dev/vxge/vxge.c	Thu Feb 23 16:07:45 2017	(r314144)
>> +++ head/sys/dev/vxge/vxge.c	Thu Feb 23 16:10:15 2017	(r314145)
>> @@ -2312,7 +2312,7 @@ vxge_vpath_open(vxge_dev_t *vdev)
>>  		vpath->rx_ticks = ticks;
>>
>>  		vpath->tti_rtimer_val = VXGE_DEFAULT_TTI_RTIMER_VAL;
>> -		vpath->tti_rtimer_val = VXGE_DEFAULT_TTI_RTIMER_VAL;
>> +		vpath->rti_rtimer_val = VXGE_DEFAULT_TTI_RTIMER_VAL;
>
> Probably use VXGE_DEFAULT_<R>TI_RTIMER_VAL instead of <T>TI?
>
Good catch, fixed as r314158.

Thanks!

Pedro.


More information about the svn-src-head mailing list