svn commit: r321849 - in head/tools/tools: bootparttest zfsboottest

[Andriy Gapon]

On 01/08/2017 09:51, Ngie Cooper (yaneurabeya) wrote:
> 
>> On Jul 31, 2017, at 23:39, Andriy Gapon <avg at FreeBSD.org> wrote:
>>
>> On 01/08/2017 08:29, Ngie Cooper wrote:
>>> Author: ngie
>>> Date: Tue Aug  1 05:29:36 2017
>>> New Revision: 321849
>>> URL: https://svnweb.freebsd.org/changeset/base/321849
>>>
>>> Log:
>>>  Fix the return type for pager_output(..) in bootparttest and zfsboottest
>>>
>>>  pager_output(..) has always returned int. For some reason (probably the
>>>  clang 5.0 update), this mismatch now results in an error with CC=clang.
>>>
>>>  MFC after:	1 week
>>
>> I am not sure if this a correct fix...
>> Return value of pager_output() signifies whether to continue printing, return
>> value of printf is a number of characters printed.
> 
> You’re right — it was wrong. Fixed in r321852.

Thank you!
The next problem you are going to encounter would be missing ldi_get_size().
I have some WIP for that if you are interested.


-- 
Andriy Gapon