svn commit: r305032 - head/sys/dev/cxgbe

[John Baldwin]

On Monday, August 29, 2016 10:47:14 PM John Baldwin wrote:
> Author: jhb
> Date: Mon Aug 29 22:47:14 2016
> New Revision: 305032
> URL: https://svnweb.freebsd.org/changeset/base/305032
> 
> Log:
>   Use device_verbose() to undo device_quiet() when detaching from t[45]iovX.
>   
>   The device quiet flag is not automatically reset on detach, so it is
>   inherited by other device drivers (e.g. when switching a device driver
>   over to ppt for PCI pass through).  Cope with this behavior by explicitly
>   marking the device verbose during detach so that the next driver can make
>   its own decision.
>   
>   Sponsored by:	Chelsio Communications

Even though device_quiet() is documented to work this way, I think it is probably
worth considering changing this so it only affects a single attach/detach life
cycle.  That is, clearing the flag in device_detach() (but also handling
device_probe() correctly since it is typically called during probe and if
multiple drivers probe a device, you only want the behavior of the "winning"
driver to be in effect when you call attach).

-- 
John Baldwin