svn commit: r304606 - head/sys/netinet

[Ryan Stone]

Author: rstone
Date: Mon Aug 22 15:27:37 2016
New Revision: 304606
URL: https://svnweb.freebsd.org/changeset/base/304606

Log:
  Temporarily disable the optimization from r304436
  
  r304436 attempted to optimize the handling of incoming UDP packet by only
  making an expensive call to in_broadcast() if the mbuf was marked as an
  broadcast packet.  Unfortunately, this cannot work in the case of point-to-
  point L2 protocols like PPP, which have no notion of "broadcast".
  
  Discussions on how to properly fix r304436 are ongoing, but in the meantime
  disable the optimization to ensure that no existing network setups are broken.
  
  Reported by:	bms

Modified:
  head/sys/netinet/udp_usrreq.c

Modified: head/sys/netinet/udp_usrreq.c
==============================================================================
--- head/sys/netinet/udp_usrreq.c	Mon Aug 22 15:01:39 2016	(r304605)
+++ head/sys/netinet/udp_usrreq.c	Mon Aug 22 15:27:37 2016	(r304606)
@@ -126,7 +126,7 @@ SYSCTL_INT(_net_inet_udp, OID_AUTO, blac
     &VNET_NAME(udp_blackhole), 0,
     "Do not send port unreachables for refused connects");
 
-static VNET_DEFINE(int, udp_require_l2_bcast) = 1;
+static VNET_DEFINE(int, udp_require_l2_bcast) = 0;
 #define	V_udp_require_l2_bcast		VNET(udp_require_l2_bcast)
 SYSCTL_INT(_net_inet_udp, OID_AUTO, require_l2_bcast, CTLFLAG_VNET | CTLFLAG_RW,
     &VNET_NAME(udp_require_l2_bcast), 0,