svn commit: r303763 - in head/sys/cddl: compat/opensolaris/sys contrib/opensolaris/uts/common/fs/zfs contrib/opensolaris/uts/common/fs/zfs/sys

[Andriy Gapon]

On 09/08/2016 08:10, Andriy Gapon wrote:
> On 09/08/2016 02:48, Navdeep Parhar wrote:
>> Hello Andriy,
>>
>> I'm at r303837 and have had two panics today in zfs_rename.  I have a
>> core for a kernel built with -O0.  Let me know if you think it's related
>> to this commit and need more information.  This is the stack:
>>
>> (also available at https://people.freebsd.org/~np/rename_panic.txt in
>> case the wide lines are hard to read in email).
> 
> Thank you very much for the report.
> More details are required for analysis. In frame 11 I would like to see objects
> pointed to by all arguments and additionally local variables tdzp, sdzp, zfsvfs
> and zilog.

Navdeep,

thank you for the debugging information (provided out-of-band).
The problem seems to be with leaving a variable uninitialized when a
cross-device rename is detected and then accessing that variable before checking
the error code.  Also, thank you for testing a fix.  I'll commit it very soon.

-- 
Andriy Gapon