svn commit: r303047 - head/usr.bin/sed

[Pedro Giffuni]

Hello;

On 08/02/16 09:54, Guido Falsi wrote:
> On 08/02/16 16:17, Alexey Dokuchaev wrote:
>> On Tue, Jul 19, 2016 at 10:56:40PM +0000, Pedro F. Giffuni wrote:
>>> New Revision: 303047
>>> URL: https://svnweb.freebsd.org/changeset/base/303047
>>>
>>> Log:
>>>   sed(1):	Assorted cleanups and simplifications.
>>>
>>>   Const-ify several variables, make it build cleanly with WARNS level 5.
>>>
>>>   Submitted by:	mi
>>>   PR:		195929
>>>   MFC after:	1 month
>>
>> Hi Pedro,
>>
>> This change causes `games/openttd' to fail now, because the generated
>> `$wrkdir/openttd-1.6.1/objs/release/Makefile' file is broken (SRCS var
>> is set to bogus value, search for ^SRCS).  Reverting usr.bin/sed back
>> to r303046 fixes it.
>>
>> The latest revision (with ngie@'s fix) exhibits the same problem.
>>
>> Now the port uses somewhat obscure build system, but the sed(1) magic
>> happens inside generate_foo() functions using SRC_REPLACE variable set
>> in make_sed() inside `config.lib' file; these functions are called by
>> the configure script.
>>
>> Would you or Mikhail mind taking a look?  Thanks,
>
> By chance I had a look at this, thinking it was a local problem on my
> machine, and noticed that the substitutions get truncated at exactly
> 5120 characters. Looks like some hardcoded 5KiB buffer.
>

Thank you for the reports, this type of things make nice cases for the
test suite.

There were good reasons this patch was not meant for 11.0-RELEASE. Given 
it's the second regression and I am not satisfied with the patch for the 
first one, I will be reverting the change so we can look at
the problems integrally.

Pedro.