svn commit: r297762 - head/sys/dev/ichiic

[Steven Hartland]

On 09/04/2016 22:00, John Baldwin wrote:
> On Saturday, April 09, 2016 09:29:57 PM Steven Hartland wrote:
>> Hi John, it would be nice if the commit message clarified why the change
>> was made, as well as what was changed. This would allow others like
>> myself to learn about the reasons for changes like this, which aren't
>> self explanatory.
> Sleeping with a timeout doesn't (currently) work during the initial device
> time probe.  All sleep requests used to just return immediately without any
> delay.  I recently changed it so that infinite sleeps (no timeout) now work
> in preparation for ongoing work to start APs earlier during the boot.
> However, we still can't manage timeouts until we have timers and interrupts
> from timers, so sleeps with timeouts will now panic (instead of just
> returning instantly which the code here probably did not expect).  The
> assertion highlighted that this driver was using a tight spin loop during
> boot-time attach instead of polling the device periodically (as the author
> probably thought they were doing).
>
Thanks for the explanation John, most appreciated :)

     Regards
     Steve