svn commit: r280154 - head/usr.sbin/bhyve

[Bryan Venteicher]

On Mon, Mar 16, 2015 at 3:13 PM, Alexander Motin <mav at freebsd.org> wrote:

> Author: mav
> Date: Mon Mar 16 20:13:25 2015
> New Revision: 280154
> URL: https://svnweb.freebsd.org/changeset/base/280154
>
> Log:
>   Report that we may have write cache, and that we do support FLUSH.
>
>   FreeBSD guest driver does not use that legacy flag, but Linux seems does.
>
>

The guest driver calls it by a prior name: VIRTIO_BLK_F_WCE. The write
cache stuff went through several iterations, and goes away in VirtIO 1.0
specification.



>   MFC after:    2 weeks
>
> Modified:
>   head/usr.sbin/bhyve/pci_virtio_block.c
>
> Modified: head/usr.sbin/bhyve/pci_virtio_block.c
>
> ==============================================================================
> --- head/usr.sbin/bhyve/pci_virtio_block.c      Mon Mar 16 20:00:09 2015
>       (r280153)
> +++ head/usr.sbin/bhyve/pci_virtio_block.c      Mon Mar 16 20:13:25 2015
>       (r280154)
> @@ -64,6 +64,7 @@ __FBSDID("$FreeBSD$");
>  /* Capability bits */
>  #define        VTBLK_F_SEG_MAX         (1 << 2)        /* Maximum request
> segments */
>  #define        VTBLK_F_BLK_SIZE        (1 << 6)        /* cfg block size
> valid */
> +#define        VTBLK_F_FLUSH           (1 << 9)        /* Cache flush
> support */
>  #define        VTBLK_F_TOPOLOGY        (1 << 10)       /* Optimal I/O
> alignment */
>
>  /*
> @@ -72,6 +73,7 @@ __FBSDID("$FreeBSD$");
>  #define VTBLK_S_HOSTCAPS      \
>    ( VTBLK_F_SEG_MAX  |                                             \
>      VTBLK_F_BLK_SIZE |                                             \
> +    VTBLK_F_FLUSH    |                                             \
>      VTBLK_F_TOPOLOGY |                                             \
>      VIRTIO_RING_F_INDIRECT_DESC )      /* indirect descriptors */
>
>
>