svn commit: r284116 - head/sys/boot/ficl

[Garrett Cooper]

> On Jun 7, 2015, at 07:20, Marcelo Araujo <araujo at FreeBSD.org> wrote:
> 
> Author: araujo (ports committer)
> Date: Sun Jun  7 14:20:48 2015
> New Revision: 284116
> URL: https://svnweb.freebsd.org/changeset/base/284116
> 
> Log:
>  Include header libi386.h to silence the clang warning of implicit declaration
>  of functions biospci_*.
> 
>  Differential Revision:    D2668
>  Reviewed by:        rodrigc
> 
> Modified:
>  head/sys/boot/ficl/loader.c
> 
> Modified: head/sys/boot/ficl/loader.c
> ==============================================================================
> --- head/sys/boot/ficl/loader.c    Sun Jun  7 13:59:02 2015    (r284115)
> +++ head/sys/boot/ficl/loader.c    Sun Jun  7 14:20:48 2015    (r284116)
> @@ -46,6 +46,7 @@
> #include "bootstrap.h"
> #include <string.h>
> #include "ficl.h"
> +#include "../i386/libi386/libi386.h"

Hi Marcelo,

This commit's explicitly polluting the ficl interpreter with code from x86 on all platforms. Seems like the code should be refactored to not explicitly include this symbol, then #include this header there. That's the real bug..

Also, I'm not a huge fan of relative #include's. I prefer using CFLAGS with -I (mostly personal preference, however I think it affects file generation too).

Thanks!