svn commit: r277737 - in head: etc/pam.d tools/build/mk

[Warner Losh]

> On Jan 26, 2015, at 7:26 PM, Garrett Cooper <yaneurabeya at gmail.com> wrote:
> 
> On Jan 26, 2015, at 4:23, Dag-Erling Smørgrav <des at des.no> wrote:
> 
>> Garrett Cooper <ngie at FreeBSD.org> writes:
>>> Log:
>>> Honor MK_ACCT with etc/pam.d/atrun
>> 
>> The correct idiom would be
> 
> I disagree for a few reasons:
> 1. style.Makefile(9) makes no mention of having to use an idiom over the other.
> 2. The likelihood of typos creeping into Makefiles is greater with the _foo= idiom.
> 3. It creates unnecessary local variables — especially when appending is so easy to do.
> 4. It’s more difficult when backporting changes to do it with the variable method — especially if context around the line modified has changed a great deal.

5. I’m working on a change that would be easier to do with Garrett’s change, but it is rather invasive so I need to work it through a good chunk of the system before I offer it for review and discussion.

Warner