svn commit: r277798 - head/bin/expr

[NGie Cooper]

On Tue, Jan 27, 2015 at 10:04 AM, Stefan Esser <se at freebsd.org> wrote:
> Author: se
> Date: Tue Jan 27 18:04:41 2015
> New Revision: 277798
> URL: https://svnweb.freebsd.org/changeset/base/277798
>
> Log:
>   Fix overflow check for multiplication:
>   - Add special test to detect the case of -1 * INTMAX_MIN
>   - Protect against elimination of the test division by the optimizer
>
>   Garrett Cooper noticed that the overflow checks were incomplete, and Bruce
>   Evans suggested the use of the "volatile" qualifier to counter the effect
>   of the undefined behaviour, when the prior multiplication caused overflow,
>   and he also suggested improvements to the comments.
>
>   Reviewed by:  bde
>   MFC after:    1 week

Thank you bde and se for all your hard work and discussion in
resolving this issue!! It was really awesome watching the discussion
back and forth :).