svn commit: r277530 - head/sys/netinet

Gleb Smirnoff glebius at FreeBSD.org
Thu Jan 22 23:03:57 UTC 2015


On Thu, Jan 22, 2015 at 05:09:54PM +0000, Will Andrews wrote:
W> Author: will
W> Date: Thu Jan 22 17:09:54 2015
W> New Revision: 277530
W> URL: https://svnweb.freebsd.org/changeset/base/277530
W> 
W> Log:
W>   Improve CARP logging so that all state transitions are logged.
W>   
W>   sys/netinet/ip_carp.c:
W>   	Add a "reason" string parameter to carp_set_state() and
W>   	carp_master_down_locked() allowing more specific logging
W>   	information to be passed into these apis.
W>   
W>   	Refactor existing state transition logging into a single
W>   	log call in carp_set_state().
W>   
W>   	Update all calls to carp_set_state() and
W>   	carp_master_down_locked() to pass an appropriate reason
W>   	string.  For state transitions that were previously logged,
W>   	the output should be unchanged.
W>   
W>   Submitted by:	gibbs (original), asomers (updated)
W>   MFC after:	1 week
W>   Sponsored by:	Spectra Logic
W>   MFSpectraBSD:	1039697 on 2014/02/11 (original)
W>   		1049992 on 2014/03/21 (updated)

Very nice, thanks!

The only thing I'd suggest to change is "SIOCSVH". You and me, we understand
this enchantment word, but average user Joe doesn't. :) May be a text like
"user requested" or something else. I don't insist on anything, as I am not
native speaker, but anything except of SIOCSVH :)

P.S. Abbreviation "hw" might also be improved.

-- 
Totus tuus, Glebius.


More information about the svn-src-head mailing list