svn commit: r277213 - in head: share/man/man9 sys/kern sys/ofed/include/linux sys/sys
Gleb Smirnoff
glebius at FreeBSD.org
Thu Jan 15 17:14:34 UTC 2015
Hans,
On Thu, Jan 15, 2015 at 05:05:58PM +0100, Hans Petter Selasky wrote:
H> > Eh, I have not reviewed this at all. (I still plan to though.)
H>
H> The "Reviewed by" was simply a C&P of the review list in from the
H> Differential Revision. When you mention it should probably simply have said:
H>
H> Reviewed by: sbruno @
H>
H> Due to the meaning of "Reviewed by" in commit messages. Sorry.
H>
H> BTW: Nice if people respond quickly or remove themselves from the
H> differential reviews if they don't plan to do any reviews.
I'd dare to say that such important change simply cannot be committed
with a thorough review from at least two people very confident in this
area.
Look at r247777. This is the way it should be done.
--
Totus tuus, Glebius.
More information about the svn-src-head
mailing list