svn commit: r277030 - head/sys/netinet

Michael Tuexen tuexen at FreeBSD.org
Sun Jan 11 21:44:57 UTC 2015


Author: tuexen
Date: Sun Jan 11 21:44:56 2015
New Revision: 277030
URL: https://svnweb.freebsd.org/changeset/base/277030

Log:
  Remove dead code.
  
  Reported by:	Coverity
  CID:		748666
  MFC after:	1 week

Modified:
  head/sys/netinet/sctp_pcb.c

Modified: head/sys/netinet/sctp_pcb.c
==============================================================================
--- head/sys/netinet/sctp_pcb.c	Sun Jan 11 21:39:28 2015	(r277029)
+++ head/sys/netinet/sctp_pcb.c	Sun Jan 11 21:44:56 2015	(r277030)
@@ -2166,11 +2166,6 @@ sctp_findassoc_by_vtag(struct sockaddr *
 	SCTP_INP_INFO_RLOCK();
 	head = &SCTP_BASE_INFO(sctp_asochash)[SCTP_PCBHASH_ASOC(vtag,
 	    SCTP_BASE_INFO(hashasocmark))];
-	if (head == NULL) {
-		/* invalid vtag */
-		SCTP_INP_INFO_RUNLOCK();
-		return (NULL);
-	}
 	LIST_FOREACH(stcb, head, sctp_asocs) {
 		SCTP_INP_RLOCK(stcb->sctp_ep);
 		if (stcb->sctp_ep->sctp_flags & SCTP_PCB_FLAGS_SOCKET_ALLGONE) {
@@ -6751,10 +6746,6 @@ sctp_is_vtag_good(uint32_t tag, uint16_t
 	SCTP_INP_INFO_RLOCK();
 	head = &SCTP_BASE_INFO(sctp_asochash)[SCTP_PCBHASH_ASOC(tag,
 	    SCTP_BASE_INFO(hashasocmark))];
-	if (head == NULL) {
-		/* invalid vtag */
-		goto skip_vtag_check;
-	}
 	LIST_FOREACH(stcb, head, sctp_asocs) {
 		/*
 		 * We choose not to lock anything here. TCB's can't be
@@ -6778,8 +6769,6 @@ sctp_is_vtag_good(uint32_t tag, uint16_t
 			return (0);
 		}
 	}
-skip_vtag_check:
-
 	chain = &SCTP_BASE_INFO(vtag_timewait)[(tag % SCTP_STACK_VTAG_HASH_SIZE)];
 	/* Now what about timed wait ? */
 	LIST_FOREACH(twait_block, chain, sctp_nxt_tagblock) {


More information about the svn-src-head mailing list