svn commit: r277300 - in head: cddl/contrib/opensolaris/cmd/dtrace cddl/contrib/opensolaris/cmd/lockstat cddl/contrib/opensolaris/cmd/mdb/tools/common cddl/contrib/opensolaris/cmd/plockstat cddl/co...

[Pedro Giffuni]

On 18/02/2015 01:36 p.m., Rui Paulo wrote:
> On Jan 17, 2015, at 06:45 AM, Steven Hartland <smh at FreeBSD.org> wrote:
>
>> Author: smh
>> Date: Sat Jan 17 14:44:59 2015
>> New Revision: 277300
>> URL: https://svnweb.freebsd.org/changeset/base/277300
>>
>> Log:
>> Mechanically convert cddl sun #ifdef's to illumos
>>
>> Since the upstream for cddl code is now illumos not sun, mechanically
>> convert all sun #ifdef's to illumos #ifdef's which have been used in all
>> newer code for some time.
>>

FWIW, we should probably "svn move" contrib/cddl/opensolaris to 
contrib/cddl/illumos as well.
"opensolaris" doesn't exist anymore but "illumos" is also shorter.

>> Also do a manual pass to correct the use if #ifdef comments as per 
>> style(9)
>> as well as few uses of #if defined(__FreeBSD__) vs #ifndef illumos.
> I had just convinced Mark Johnston to use "#ifdef __FreeBSD__" instead 
> of "#ifndef illumos".  Is there a reason why we keep using #ifndef ? 
>  To me, it's much easier to read #ifdef __FreeBSD__ than to note 
> whether theres an "n" in that pre-processor macro.
>

Pedro.