svn commit: r292777 - in head: lib/libc/sys sys/kern

Konstantin Belousov kostikbel at gmail.com
Mon Dec 28 08:13:27 UTC 2015


On Mon, Dec 28, 2015 at 09:35:11AM +1100, Bruce Evans wrote:
> If this causes a panic, then it is from a sanity check detecting the
> invalid conversion later.  A negative value in days breaks the loop
> logic but seems to give premature exit from the loops instead of many
> iterations.
It causes the panic due to out of bound accesses to bin2bcd_data[] array.
The issue affects around twenty rtc drivers, according to the quick grep
for clock_ts_to_ct() usage.  It probably also affects geom raid modules,
but I did not looked there at all.

As I understand, people prefer to have ability to test practically
useless values for the current time, by the cost the unplugged easy
kernel panic, in the production systems ? Am I right ? The commit gave
the immediate relief for the issue. If somebody have the correct fix
for clock_ts_to_ct(), I am happy to see this commit reverted after the
proper fix.


More information about the svn-src-head mailing list