svn commit: r292379 - in head/sys: netinet netinet6

[Gleb Smirnoff]

  Steven,

  I'm sorry that wasn't able to review D4111 in time, but I have
very strong concerns against r292275. And r292379 doesn't
improve situation. I am asking you to back out both patches,
and then we can get together back to the problem. The 156226
bug was sitting for 2 years in the bugzilla for a reason. It
is a not "low hanging fruit" like koobs@ says.

I'm sorry if I sound unforgiving, but you got a very bad commit
record in this area. You committed r290403 to ip_carp.c which
"added MTU support to carp interfaces", and that was after 4 YEARS
of carp(4) being not an interface. So, I assume you doesn't
have a good understanding of the current state of the stack,
direction it is developed and things that can be done and
can not (including DELAY() in callout(9).

Note, that the MAINTAINERS file still lists me for ip_carp.c,
and you didn't wait for my review. yet another reason to ask
for backout.

I understand that you got a product at work that needs to
have problem fixed. I'm glad that you got a patch that works
it around. But that doesn't mean the patch should immeditely
be dumped in head with a threat of soon MFC.

-- 
Totus tuus, Glebius.