svn commit: r291955 - in head: . share/mk

[Bryan Drewery]

On 12/7/15 11:15 AM, Ed Maste wrote:
> Author: emaste
> Date: Mon Dec  7 19:15:52 2015
> New Revision: 291955
> URL: https://svnweb.freebsd.org/changeset/base/291955
> 
> Log:
>   Build and install userland .debug files by default
>   
>   Debug data files are now built by default with 'make buildworld' and
>   installed with 'make installworld'. This facilitates debugging but
>   requires more disk space both during the build and for the installed
>   world. Debug files may be disabled by setting WITHOUT_DEBUG_FILES=yes
>   in src.conf(5).
>   
>   Reviewed by:	bdrewery, eadler, vangyzen
>   Relnotes:	Yes
>   Sponsored by:	The FreeBSD Foundation
>   Differential Revision:	https://reviews.freebsd.org/D4018
> 
> Modified:
>   head/UPDATING
>   head/share/mk/bsd.opts.mk
> 
> Modified: head/UPDATING
> ==============================================================================
> --- head/UPDATING	Mon Dec  7 19:08:33 2015	(r291954)
> +++ head/UPDATING	Mon Dec  7 19:15:52 2015	(r291955)
> @@ -31,6 +31,13 @@ NOTE TO PEOPLE WHO THINK THAT FreeBSD 11
>  	disable the most expensive debugging functionality run
>  	"ln -s 'abort:false,junk:false' /etc/malloc.conf".)
>  
> +20151207:
> +	Debug data files are now built by default with 'make buildworld' and
> +	installed with 'make installworld'. This facilitates debugging but
> +	requires more disk space both during the build and for the installed
> +	world. Debug files may be disabled by setting WITHOUT_DEBUG_FILES=yes
> +	in src.conf(5).
> +
>  20151130:
>  	r291527 changed the internal interface between the nfsd.ko and
>  	nfscommon.ko modules. As such, they must both be upgraded to-gether.
> 
> Modified: head/share/mk/bsd.opts.mk
> ==============================================================================
> --- head/share/mk/bsd.opts.mk	Mon Dec  7 19:08:33 2015	(r291954)
> +++ head/share/mk/bsd.opts.mk	Mon Dec  7 19:15:52 2015	(r291955)
> @@ -50,6 +50,7 @@ __<bsd.opts.mk>__:
>  
>  __DEFAULT_YES_OPTIONS = \
>      ASSERT_DEBUG \
> +    DEBUG_FILES \
>      DOCCOMPRESS \
>      INCLUDES \
>      INSTALLLIB \
> @@ -69,7 +70,6 @@ __DEFAULT_NO_OPTIONS = \
>      CCACHE_BUILD \
>      FAST_DEPEND \
>      CTF \
> -    DEBUG_FILES \
>      INSTALL_AS_USER \
>      STALE_STAGED
>  
> 

I just noticed. This will cause ports that use /usr/share/mk to now
generate .debug files and have plist errors.

I'm thinking of the right way to handle this. I want to handle symbols
in ports differently than DEBUG_FILES, so I think I will force
MK_DEBUG_FILES=no for ports builds. I have pending work to complete to
bring symbols support to all of ports, not just those using /usr/share/mk.

-- 
Regards,
Bryan Drewery