svn commit: r269577 - in head/sys: amd64/include arm/arm arm/include conf i386/i386 i386/include kern mips/include mips/mips powerpc/include powerpc/powerpc sparc64/include sparc64/sparc64 sys

[Adrian Chadd]

On 6 September 2014 15:01, Alan Cox <alc at rice.edu> wrote:
> On 09/06/2014 16:15, Adrian Chadd wrote:
>> Hi Gleb!
>>
>> This commit has broken mips32 on my 128MB RAM routerstation pro board.
>>
>> I've tested the commit before this one (and it works).
>>
>> I've also tested today's -HEAD as there was some subsequent fixes to
>> the sfbuf code. It hasn't completely fixed things - I still see
>> processes throwing VM errors:
>
>
> Before this commit, the sf_buf code did not cache mappings on MIPS.
> Now, it does.  So, I suspect that you're experiencing cache consistency
> issues.  To return to the pre-commit state, you'll need to define
> machine-dependent sf_buf_{un,}map() functions in mips/include/sf_buf.h
> for mips32 that call pmap_q{remove,enter}, respectively.  Look at arm
> for a similar configuration.

Yup, I just noticed that, fixed it, and updated the bug (bug 193400.)

Is this something that should be fixed in the vm/pmap code somewhere,
or is this just the correct behaviour?


-a